Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in required override for JWPlayerDelegate #103

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

Jmilham21
Copy link
Collaborator

What does this Pull Request do?

  • Fix broken RNJWPlayerView.swift

Why is this Pull Request needed?

  • We removed the wrong override
    • Needed to keep jwplayerContentIsBuffering for JWPlayerDelegate

Are there any points in the code the reviewer needs to double check?

  • no

Are there any Pull Requests open in other repos which need to be merged with this?

  • no

Addresses Issue(s):

ADHOC

@Jmilham21 Jmilham21 merged commit 40b604c into master Dec 5, 2024
@Jmilham21 Jmilham21 deleted the patch/fix-ios-delegate-overrides branch December 5, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants